-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients #7954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame web & native app clients
4 tasks
jhockett
reviewed
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! @lazpavel can we add a regression test?
…ame web & native app clients
…cli into auth-import-web-native
…cli into auth-import-web-native
…cli into auth-import-web-native
jhockett
approved these changes
Aug 19, 2021
jhockett
pushed a commit
that referenced
this pull request
Aug 25, 2021
…ame web & native app clients (#7954) * fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients * fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients
github-actions
bot
added
the
referenced-in-release
Issues referenced in a published release changelog
label
Sep 2, 2021
👋 Hi, this pull request was referenced in the v5.4.0 release! Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0. |
marcvberg
pushed a commit
to marcvberg/amplify-cli
that referenced
this pull request
Oct 13, 2021
…ame web & native app clients (aws-amplify#7954) * fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients * fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #7949
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.