Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients #7954

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Conversation

lazpavel
Copy link
Contributor

Description of changes

  • made sure that the prompt loop has a way to terminate

Issue #7949

Description of how you validated changes

  • reproduced the issue with production version
  • manually tested the changes and confirmed the issue is fixed

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! @lazpavel can we add a regression test?

@lazpavel lazpavel changed the base branch from master to FF-codegen August 19, 2021 18:42
@lazpavel lazpavel changed the base branch from FF-codegen to master August 19, 2021 18:42
@cjihrig cjihrig merged commit 49d0e51 into aws-amplify:master Aug 25, 2021
jhockett pushed a commit that referenced this pull request Aug 25, 2021
…ame web & native app clients (#7954)

* fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients

* fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients
@github-actions github-actions bot added the referenced-in-release Issues referenced in a published release changelog label Sep 2, 2021
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

👋 Hi, this pull request was referenced in the v5.4.0 release!

Check out the release notes here https://github.com/aws-amplify/amplify-cli/releases/tag/v5.4.0.

marcvberg pushed a commit to marcvberg/amplify-cli that referenced this pull request Oct 13, 2021
…ame web & native app clients (aws-amplify#7954)

* fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients

* fix(amplify-category-auth): fixed walkthrough prompt after choosing same web & native app clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
referenced-in-release Issues referenced in a published release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import auth - after choosing the same web & native client to import, unable to reselect different clients
3 participants